Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/resolve node promise incase of failure #2802

Conversation

gravityvi
Copy link
Member

@gravityvi gravityvi commented Jul 14, 2021

Issue

  • Incase of waitFor commands with abortOnFailure=false used in async/await test hangs up as the node is neither rejected nor resolved.
module.exports= {
  'tags': ['google'],
  'sample': async function(client) {
    await client.url('https://google.com');
    await client.waitForElementVisible('#badElement', null, false);
   
  }

Changes

  • node is resolved irrespective of the condition.

@beatfactor beatfactor merged commit b23f747 into nightwatchjs:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants