Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/find elements result value in async commands #2820

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Fixes/find elements result value in async commands #2820

merged 3 commits into from
Jul 29, 2021

Conversation

gravityvi
Copy link
Member

Changes

  • update the response of findElements command to return the same result in the case of async commands.

Impact

vaibhavsingh97
vaibhavsingh97 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beatfactor
Copy link
Member

@gravityvi We might have to do the same for findElement(). Can you check that as well?

@gravityvi
Copy link
Member Author

@beatfactor, no additional changes were required for findElement. I added a test as well to support this.

@beatfactor beatfactor merged commit babd88c into nightwatchjs:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatfactor beatfactor beatfactor left review comments

@Dharin-shah Dharin-shah Dharin-shah approved these changes

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diffrent returned object between findElements async and sync version
4 participants
@gravityvi @beatfactor @Dharin-shah @vaibhavsingh97