Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transport.js #2882

Merged
merged 2 commits into from
Sep 12, 2021
Merged

Update transport.js #2882

merged 2 commits into from
Sep 12, 2021

Conversation

Topperfalkon
Copy link
Contributor

Appium can get upset if you supply both a browserName and an appPackage as desiredCapabilities at the same time.

A brief reading of an Appium issue report from a few years ago suggests it shouldn't complain, but this will fix the current behaviour to allow users to set a null browser

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

Should resolve an issue raised in discussion #2881

Appium can get upset if you supply both a browserName and an appPackage as desiredCapabilities at the same time.

A brief reading of an Appium issue report from a few years ago suggests it _shouldn't_ complain, but this will fix the current behaviour to allow users to set a null browser
@CLAassistant
Copy link

CLAassistant commented Aug 27, 2021

CLA assistant check
All committers have signed the CLA.

@beatfactor
Copy link
Member

Thanks for submitting this. Does this cover it?

@Topperfalkon
Copy link
Contributor Author

Yeah, turned out a lot simpler than I thought 😄

So, now, if you pass through browserName: null, in your suite's config, this should just pass all the way through without error. Before it was falling into the browserName.toLowerCase() operation and erroring.

I had a brief look at the v2 branch and I think that'll have a similar problem, but that area's changed quite a bit so I haven't attempted a fix on that branch

@Topperfalkon
Copy link
Contributor Author

@beatfactor do you need anything else from me on this one? It seems to just be waiting for another reviewer

@beatfactor
Copy link
Member

A small test will be needed. I'll merge it in soon.

@beatfactor beatfactor merged commit d2fd8ba into nightwatchjs:main Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants