feat: add support for multiple reporters #3003
Conversation
yes, it work for both |
lib/reporter/global-reporter.js
Outdated
| loadFile(reporterFile) { | ||
| const builtInReporterFileName = path.join(__dirname, 'reporters', reporterFile + '.js'); | ||
|
|
||
| return Utils.fileExists(builtInReporterFileName).then((fileExists) => { | ||
| if (!fileExists) { | ||
| return this.loadCustomReporter(reporterFile); | ||
| } | ||
|
|
||
| return require(builtInReporterFileName); | ||
| }); |
There was a problem hiding this comment.
@gravityvi This takes care of both built-in reporter and custom reporter
There was a problem hiding this comment.
Yes, but it generates a single report with one --reporter CLI value. Could we update it to generate the default builtInReporter every time along with the reporter mentioned via CLI
There was a problem hiding this comment.
yup, we can do that. I will update the PR
lib/reporter/global-reporter.js
Outdated
| return require(builtInReporterFileName); | ||
| }); | ||
| if (!builtInReporter.includes(this.reporterFile)) { | ||
| this.reporterFile = ['junit', this.reporterFile]; |
There was a problem hiding this comment.
this.reporterFile when sending --reporter html.js,junit from CLI comes out as a string 'html.js,junit', while an array is expected over here. We need to take care of that while getting cli args. Can you add a test for that as well.
There was a problem hiding this comment.
At max, this implementation can generate two reporters for a single test run.
There was a problem hiding this comment.
I think it's not meant to be used like that, we need to pass --reporter junit --reporter html.js, but I will amend it to make use of the example you mentioned, as commonly people would prefer that
There was a problem hiding this comment.
The behaviour of using multiple reporters should be:
- pass the reporters via
nightwatch --reporter test_reporter.js --reporter junit
This is necessary because we have to keep the existing behaviour where you are using a custom reporter without using the junit reporter.
The test needs to reflect this so you need to write something like here: https://github.com/nightwatchjs/nightwatch/blob/main/test/src/runner/testRunnerSessionCreate.js#L133
runTests({
reporter: ['junit', 'other-reporter-file.js']
}, {
output_folder: true
});
| }); | ||
| }); | ||
|
|
||
| it('test run tests with multiple reporters - html, junit, json', function () { |
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
features/my-new-featureorissue/123-my-bugfix);fixes #2588