Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept standard browserstack environment variables #3148

Merged
merged 10 commits into from
May 11, 2022

Conversation

Ankit098
Copy link
Contributor

@Ankit098 Ankit098 commented Apr 13, 2022

BROWSERSTACK_USERNAME and BROWSERSTACK_ACCESS_KEY are the env variables specified in docs, check for these. Also accept buildName, local if sent inside 'bstack:options'
Added an issue here: #3149

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

BROWSERSTACK_USERNAME and BROWSERSTACK_ACCESS_KEY are the env variables specified in docs, check for these. Also accept buildName, local if sent inside 'bstack:options'
@CLAassistant
Copy link

CLAassistant commented Apr 13, 2022

CLA assistant check
All committers have signed the CLA.

@gravityvi
Copy link
Member

gravityvi commented Apr 13, 2022

Thanks @Ankit098 for raising this PR, can you fix the lint issues.

Copy link
Member

@gravityvi gravityvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything mentioned in nightwatch config as ${ENV_VARIABLE} is replaced by process.env.ENV_VARIABLE so we don't need to change the variable names in config.

lib/transport/selenium-webdriver/browserstack.js Outdated Show resolved Hide resolved
lib/transport/selenium-webdriver/browserstack.js Outdated Show resolved Hide resolved
@Ankit098 Ankit098 requested a review from gravityvi April 22, 2022 05:31
@@ -41,19 +44,26 @@ class Browserstack extends Selenium {
this.settings.webdriver.start_process = false;
this.settings.webdriver.port = Number(this.settings.webdriver.port);

const {desiredCapabilities} = this.settings;
//checking for legacy-ways for providing config
this.bstackOptions = Object.assign({}, {userName: desiredCapabilities['browserstack.user'], accessKey: desiredCapabilities['browserstack.key'], buildName: desiredCapabilities.build, local: desiredCapabilities['browserstack.local']});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you format this properly? we don't have lines this long anywhere in the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants