Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDP Commands support (all commands in single PR) #3208

Merged
merged 43 commits into from
Jun 13, 2022

Conversation

garg3133
Copy link
Member

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

Copy link
Member

@beatfactor beatfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a new base class for all the CDP commands with common methods to validate the current driver

@garg3133
Copy link
Member Author

we need a new base class for all the CDP commands with common methods to validate the current driver

This PR is already too long, can we do this in a separate PR after getting this merged?

And what are the exact requirements of the new base class, will it extend the ClientCommand from _base-command.js and just have an additional method to validate the current driver, or should we rewrite the _base-command.js in it according to the specific requirements of the CDP commands and do not extend any other class in it.

@beatfactor
Copy link
Member

we need a new base class for all the CDP commands with common methods to validate the current driver

This PR is already too long, can we do this in a separate PR after getting this merged?

And what are the exact requirements of the new base class, will it extend the ClientCommand from _base-command.js and just have an additional method to validate the current driver, or should we rewrite the _base-command.js in it according to the specific requirements of the CDP commands and do not extend any other class in it.

I think it should be part of this PR because it will actually make it a bit shorter. It's up to you to decide what to put in the base class.

@beatfactor beatfactor merged commit 0d9bc01 into nightwatchjs:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants