Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: flag in nightwatch cli #3246

Merged
merged 8 commits into from
Aug 17, 2022

Conversation

vaibhavsingh97
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 commented Jun 20, 2022

Fixes #3231

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

Output after using --list-files flag:
image

@vaibhavsingh97 vaibhavsingh97 marked this pull request as ready for review June 20, 2022 07:25
@vaibhavsingh97 vaibhavsingh97 requested a review from a team June 20, 2022 07:25
@gravityvi
Copy link
Member

Can we also write an option for this CLI argument to display it in the nightwatch help command and in nightwatch documentation?

@harshit-bs
Copy link
Member

@vaibhavsingh97 Please add the description of the --list-files flag here as well

@harshit-bs
Copy link
Member

can you add tests as well?

@beatfactor beatfactor merged commit 4391cab into nightwatchjs:main Aug 17, 2022
@vaibhavsingh97 vaibhavsingh97 deleted the feat/add-list-files-arg branch September 6, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add --list-files option in Nightwatch CLI, which will list all the test files present in the workspace
4 participants