Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/add native mobile support #3335

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Features/add native mobile support #3335

merged 2 commits into from
Aug 17, 2022

Conversation

gravityvi
Copy link
Member

Changes

  • added mobile support when browserName is marked null
  • changed Browsertack transport to support Browserstack app-automate

Impacts

@gravityvi
Copy link
Member Author

I've changed the base class of Browserstack transport to create Driver when browserName is marked as null. Though it's not necessary to develop an App-automate session. It creates uniformity across, as while running local appium tests browser name should be marked as null

@beatfactor beatfactor merged commit a94aa5c into nightwatchjs:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatfactor beatfactor Awaiting requested review from beatfactor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Native Mobile App
2 participants
@gravityvi @beatfactor