alwaysMatch in desiredCapabilities doesn't work

[garg3133]

Description of the bug/issue

When we put moz:firefoxOptions inside alwaysMatch, the passed options are not considered by Geckodriver while they are considered when passed without using alwaysMatch.

With alwaysMatch

      desiredCapabilities: {
        browserName: 'firefox',
        alwaysMatch: {
          acceptInsecureCerts: true,
          'moz:firefoxOptions': {
            args: [
              // '-headless',
              // '-verbose'
            ],
            androidPackage: 'org.mozilla.firefox',
            // androidDeviceSerial: 'ZD2222W62Y'
          }
        }
      }

Verbose:

Without alwaysMatch

      desiredCapabilities: {
        browserName: 'firefox',
        acceptInsecureCerts: true,
        'moz:firefoxOptions': {
          args: [
            // '-headless',
            // '-verbose'
          ],
          androidPackage: 'org.mozilla.firefox',
          // androidDeviceSerial: 'ZD2222W62Y'
        }
      }

Verbose:

Steps to reproduce

Run any test on Firefox with the above config.

Sample test

No response

Command to run

No response

Verbose Output

No response

Nightwatch Configuration

No response

Nightwatch.js Version

2.3.4

Node Version

No response

Browser

No response

Operating System

No response

Additional Information

No response

[AutomatedTester]

This is part of the work to move to 4.5 that @vaibhavsingh97 is doing

[garg3133]

Bump on this one. It's not yet fixed and users keep on facing this issue where they can't figure out why a config or arg is not working with Firefox.

/cc: @gravityvi @beatfactor

[gravityvi]

This is the case for every browser not just firefox

[garg3133]

Yes, but we use alwaysMatch in our default config file and the one created by the init tool only for Firefox, due to which config files of all our users contain alwaysMatch, which does not work.

So, I think we only need to take care of alwaysMatch for Firefox browser, while also changing our default config file in Nightwatch and the init tool to not include alwaysMatch for firefox.