Fix double free().

Found by Brian 'geeknik' Carpenter using AFL.
nih-at · Aug 14, 2017 · 2217022 · 2217022 · l2dy · Oct 8, 2017
1 parent f0b8dda
commit 2217022
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/THANKS b/THANKS
@@ -12,6 +12,7 @@ BALATON Zoltan <balaton@eik.bme.hu>
 Benjamin Gilbert <bgilbert@backtick.net>
 Boaz Stolk <bstolk@aweta.nl>
 Bogdan <bogiebog@gmail.com>
+Brian 'geeknik' Carpenter <geeknik@protonmail.ch>
 Chris Nehren <cnehren+libzip@pobox.com>
 Coverity <info@coverity.com>
 Dane Springmeyer <dane.springmeyer@gmail.com>

diff --git a/lib/zip_dirent.c b/lib/zip_dirent.c
@@ -579,9 +579,6 @@ _zip_dirent_read(zip_dirent_t *zde, zip_source_t *src, zip_buffer_t *buffer, boo
     }
 
     if (!_zip_dirent_process_winzip_aes(zde, error)) {
-	if (!from_buffer) {
-	    _zip_buffer_free(buffer);
-	}
 	return -1;
     }