Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large file support was lost in the transition to cmake #45

Closed
michaelolbrich opened this issue May 27, 2018 · 3 comments
Closed

large file support was lost in the transition to cmake #45

michaelolbrich opened this issue May 27, 2018 · 3 comments

Comments

@michaelolbrich
Copy link

The old autoconf based versions of libzip used AC_SYS_LARGEFILE for largefile support on 32 Bit platforms. With the switch to cmake this feature was lost.
32 Bit systems may be rare these days in the x86 world, but 32 Bit ARM systems are very common.
Also, this is not just about file sizes: off_t is also used for inode numbers. As a result stat() will fail if the inode number exceeds 32 Bit. This is quite common with network file systems and causes seemingly random failures.
I'm no cmake expert but libarchive seems to have a reasonable check for this. It may be a good starting point.

@0-wiz-0
Copy link
Member

0-wiz-0 commented Jun 26, 2018

Do you have a suggested patch?

@0-wiz-0
Copy link
Member

0-wiz-0 commented Aug 17, 2018

Please try 55e1bfa

@0-wiz-0
Copy link
Member

0-wiz-0 commented Sep 2, 2018

We backed out that commit because it broke fts.h usage.

0-wiz-0 added a commit that referenced this issue Jan 24, 2020
@0-wiz-0 0-wiz-0 closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants