Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor and assorted fixes #32

Merged
merged 8 commits into from
Mar 6, 2018
Merged

Appveyor and assorted fixes #32

merged 8 commits into from
Mar 6, 2018

Conversation

janisozaur
Copy link
Contributor

No description provided.

@janisozaur
Copy link
Contributor Author

I'm sure some corners could be cut here to reduce time for each run, but right now it works and tests all the configurations vcpkg has to offer, including {ARM,x86,x86-64}-UWP and native (non-UWP) ARM with MSVC.

One low-hanging fruit is caching the downloaded cmake zip, it takes around 1m30s in each job!

@dillof
Copy link
Member

dillof commented Mar 6, 2018

Thank you for getting Appveyor to work. It's greatly appreciated. Also, thanks for the assorted Windows fixes.

@janisozaur
Copy link
Contributor Author

@dillof many thanks for merging this! I hope this will ensure MSVC compatibility for all your future releases.

@IntelOrca can you verify if the symbols are no longer exposed in static builds?

@dillof once that is confirmed, would you mind doing a point-release so I can update vcpkg, as noted here: microsoft/vcpkg#2937 ?

@IntelOrca
Copy link

@janisozaur 👍 It is resolved now.

@janisozaur
Copy link
Contributor Author

@dillof @0-wiz-0 could you please do a point release with those fixes? I'd like to submit update to vcpkg and then use this updated version in OpenRCT2.

Thanks in advance.

@0-wiz-0
Copy link
Member

0-wiz-0 commented Mar 11, 2018

I've just made a 1.5.0 release with your contributions. Thank you, @janisozaur!

@ras0219-msft
Copy link

Update is pushed to Vcpkg 🛩 Thanks @janisozaur @0-wiz-0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants