Refining the README #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the readme more understandable and clearer. I still think the usage section could use some work though.
|
Also is ncnn an 'inference' framework or an 'interface' framework? I would assume 'interface', but ncnn uses the term 'inference'. |
Nova-Aurora
added a commit
to Nova-Aurora/waifu2x-ncnn-vulkan
that referenced
this pull request
Dec 7, 2020
Backporting some of the README refinements from nihui/dain-ncnn-vulkan#31.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some edits on the english README.md
I went through and fixed all the grammatical errors I could, and changed out some things to hopefully make things clearer.
I think that the usage guide and about DAIN section need some work before this gets merged though.