Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash bug v 1.2.0 #54

Closed
hempels opened this issue Sep 16, 2018 · 5 comments · Fixed by #55
Closed

Crash bug v 1.2.0 #54

hempels opened this issue Sep 16, 2018 · 5 comments · Fixed by #55

Comments

@hempels
Copy link

hempels commented Sep 16, 2018

I'm not sure what details are relevant, but our node.js app crashes immediately on startup following upgrade to version 1.2.0 of hashids. The crash is resolved by reverting to version 1.1.4. The only error message is as follows:

hashids\dist\hashids.js:4
Object.defineProperty(Hashids, "__esModule", {value: true});
       ^

TypeError: Object.defineProperty called on non-object
    at Function.defineProperty (native)
    at Object.<anonymous> (...\node_modules\hashids\dist\hashids.js:4:8)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous>
@hempels hempels changed the title Major crash bug v 1.2.0 Crash bug v 1.2.0 Sep 16, 2018
@jd327
Copy link
Collaborator

jd327 commented Sep 16, 2018

Thanks for the report @hempels. What node version are you using, what os, and how do you import hashids?

cc @niieani

@clem-witii
Copy link

I've come across the same issue as well. I'm running with node v8.11.4 and use require('hasids') to import the hashids in. I've been able to repeat this error on a PC and Ubuntu.

@niieani
Copy link
Owner

niieani commented Sep 16, 2018

Sorry about this, I've tested it manually, plus in browser scenarios... I'm not sure how I managed to skip this change, but it seems it must have slipped in. Added a fix in the PR.

@jd327 jd327 closed this as completed in #55 Sep 16, 2018
jd327 pushed a commit that referenced this issue Sep 16, 2018
fix incorrect file being required (#54)
@jd327
Copy link
Collaborator

jd327 commented Sep 16, 2018

@niieani thanks, merged; 1.2.1 published.
@hempels @clem-witii does it fix the issue?

@hempels
Copy link
Author

hempels commented Sep 18, 2018

@hempels @clem-witii does it fix the issue?

Release 1.2.2 fixes the issue for us. Thank you.

niieani added a commit that referenced this issue Aug 15, 2019
niieani pushed a commit that referenced this issue Aug 15, 2019
fix incorrect file being required (#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants