Skip to content

Commit

Permalink
BREAKING CHANGE:chore: update menu.popup() API
Browse files Browse the repository at this point in the history
sync menu.popup signature to breaking change in Electron 2.0
  • Loading branch information
ckerr committed Feb 20, 2018
2 parents ea70664 + d34627b commit 83a999c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test-smoke/electron/test/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ menu.insert(0, menuItem);
console.log(menu.items);

const pos = screen.getCursorScreenPoint();
menu.popup(null, {x: pos.x, y: pos.y});
menu.popup({x: pos.x, y: pos.y});

// main.js
const template = <Electron.MenuItemConstructorOptions[]> [
Expand Down
2 changes: 1 addition & 1 deletion vendor/fetch-docs.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const mkdirp = require('mkdirp').sync
const os = require('os')

const downloadPath = path.join(os.tmpdir(), 'electron-api-tmp')
const ELECTRON_COMMIT = 'f469059e9059aa0bda756022deb53322688dac29'
const ELECTRON_COMMIT = '35e90f742b8a2f1006157da2a9f394cd055aff74'

rm(downloadPath)

Expand Down

0 comments on commit 83a999c

Please sign in to comment.