Add widget with text input (no dropdown list) #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for creating this library!
I created a Widget that allows user to manually type their phone number, as some people don't like dropdown lists.
Since I added some files, I also propose to re-organize the folder structure, eg: putting the flags in an asset folder and using an /src folder for the widgets.
I created a PhoneService class to handle the calls to libphonenumber, but I only used it in the new Widget (I didn't touch your code).
I wrote unit tests for the new Widget. I edited your test to replace async/await syntax with then(), as the test was not working.
I hope you'll find this feature interesting. I'll happily make changes if needed.