Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add widget with text input (no dropdown list) #2

Merged
merged 7 commits into from
Aug 28, 2019
Merged

Add widget with text input (no dropdown list) #2

merged 7 commits into from
Aug 28, 2019

Conversation

quang-le
Copy link
Contributor

Hi,

Thanks for creating this library!

I created a Widget that allows user to manually type their phone number, as some people don't like dropdown lists.

Since I added some files, I also propose to re-organize the folder structure, eg: putting the flags in an asset folder and using an /src folder for the widgets.

I created a PhoneService class to handle the calls to libphonenumber, but I only used it in the new Widget (I didn't touch your code).

I wrote unit tests for the new Widget. I edited your test to replace async/await syntax with then(), as the test was not working.

I hope you'll find this feature interesting. I'll happily make changes if needed.

@niinyarko
Copy link
Owner

Hi @quang-le thanks for making this request. Will review and merge.

@niinyarko niinyarko merged commit 870739f into niinyarko:master Aug 28, 2019
@quang-le
Copy link
Contributor Author

Thanks for merging. FYI, you need to update the pubspec.yaml file in the example, so it doesn't point to my repo anymore

@niinyarko
Copy link
Owner

@quang-le done. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants