Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab 4 support #41

Closed
tjni opened this issue Aug 23, 2023 · 4 comments
Closed

jupyterlab 4 support #41

tjni opened this issue Aug 23, 2023 · 4 comments

Comments

@tjni
Copy link

tjni commented Aug 23, 2023

Hello, I am new to the jupyter ecosystem, but I'm working on packaging Python projects for nixpkgs. As much as possible, we try to build a consistent package set using only the latest versions of each package. Do you know what it would take to support or upgrade to jupyterlab 4?

@christian-oreilly
Copy link
Collaborator

Good question. @AnthonyAndroulakis The reason for limiting to version 3 should be documented in an issue so that we can address it. Could you document it here when you have a moment so that we get a better sense of what effort it would involve? I think this should be addressed... it is not good to stick to old versions.

@AnthonyAndroulakis
Copy link
Contributor

It shouldn't be too much work to support Jupyterlab 4. @tjni what errors do you have when using the package in jupyterlab 4?

@tjni
Copy link
Author

tjni commented Aug 23, 2023

We don't see any errors, but I also don't think we perform the full build -- that is, we download the sdist from PyPI and I think that already contains built JS. I did see in manzt/anywidget#167 that there might be complications relating to the version of @jupyterlab/builder.

@christian-oreilly
Copy link
Collaborator

christian-oreilly commented Aug 23, 2023

@AnthonyAndroulakis On our side, I think we can try relaxing this constraint in the requirement file and the CI should block if there is an issue setting up the package to run the tests. If there is an issue with Jupyter 4 that is not caught by the CI, it just means that we will need to add the test that catches this bug. Right now, the CI is broken (issue #38) so we'll need to fix this first before we can test that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants