New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the output reproducible. #2

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@lamby
Contributor

lamby commented Nov 7, 2017

Whilst working on the Reproducible Builds effort [0], we noticed
that stardicter generates non-deterministic output in .ifo files.

In particular, it adds the current date and time.

Patch attached that uses SOURCE_DATE_EPOCH[1] if available.

[0] https://reproducible-builds.org/
[1] https://reproducible-builds.org/specs/source-date-epoch/

Make the output reproducible.
Whilst working on the Reproducible Builds effort [0], we noticed
that stardicter generates non-deterministic output in .ifo files.

In particular, it adds the current date and time.

Patch attached that uses SOURCE_DATE_EPOCH[1] if available.

 [0] https://reproducible-builds.org/
 [1] https://reproducible-builds.org/specs/source-date-epoch/
@lamby

This comment has been minimized.

Show comment
Hide comment
@lamby

lamby Nov 7, 2017

Contributor

This is being tracked in Debian at https://bugs.debian.org/881089

Contributor

lamby commented Nov 7, 2017

This is being tracked in Debian at https://bugs.debian.org/881089

@purpleidea

This comment has been minimized.

Show comment
Hide comment
@purpleidea

purpleidea commented Nov 7, 2017

LGTM

@nijel nijel merged commit 3b99c7d into nijel:master Nov 7, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nijel added a commit that referenced this pull request Nov 8, 2017

Document changes for #2
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment