Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typehints and code improvements across the board #108

Merged
merged 10 commits into from
Mar 5, 2024

Conversation

jonded94
Copy link
Contributor

  • Removed file descriptor leak in tests
  • Added typehints across the library
  • Almost mypy --strict compatible; would need drop of Python 3.8 compatibility to reach that; decided against that
  • Removed unreachable code
  • Added support for bool as option argument
  • Small spelling correction
  • Added py.typed marker file for mypy

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 98.63014% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.63%. Comparing base (84a5fc4) to head (6fb23a1).
Report is 5 commits behind head on master.

Files Patch % Lines
tidy/test_tidy.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   98.14%   98.63%   +0.48%     
==========================================
  Files           4        4              
  Lines         270      292      +22     
==========================================
+ Hits          265      288      +23     
+ Misses          5        4       -1     
Flag Coverage Δ
unittests 98.63% <98.63%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tidy/lib.py Show resolved Hide resolved
@nijel nijel merged commit b8e821d into nijel:master Mar 5, 2024
16 of 17 checks passed
@nijel
Copy link
Owner

nijel commented Mar 5, 2024

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants