fix: Fixes culture properties on content #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Introduces `IVariationContextAccessor` to the contructor on `BasicContent` Related to #145
BREAKING CHANGE: Media & Members have had culture removed from the query options. It's not possible to create media and members on different cultures and it's therefore not necessary to be able to query for it. Content & Property queries have had `segment` & `Fallback` added to the query options to better support culture querying. All `GetValue` for property values have been changed to `Value` which better support culture variants.
|
Kudos, SonarCloud Quality Gate passed! |
This was referenced May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Introduces
IVariationContextAccessorto the contructor onBasicContentMedia & Members have had culture removed from the query options. It's not possible to create media and members on different cultures and it's therefore not necessary to be able to query for it.
Content & Property queries have had
segment&Fallbackadded to the query options to better support culture querying.All
GetValuefor property values have been changed toValuewhich better support culture variants.Related to #145