Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Publish on DockerHub #6

Closed
SeanKilleen opened this issue Jul 7, 2020 · 3 comments
Closed

Suggestion: Publish on DockerHub #6

SeanKilleen opened this issue Jul 7, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@SeanKilleen
Copy link
Contributor

SeanKilleen commented Jul 7, 2020

I've noticed that every time our GitHub Action fires, it pulls from this repo, which builds the container image.

If this image was published to DockerHub, we could reference the container directly in our Action rather than building it each time, dramatically speeding up the process.

Would you be open to publishing this on DockerHub? If not, would you mind if I did so?

Thanks!

@nikeee
Copy link
Owner

nikeee commented Jul 7, 2020

I recently thought of the same. It seems to be necessary since we now install git and dotnet.

I'll see what I can do.

@nikeee nikeee self-assigned this Jul 7, 2020
@nikeee nikeee added the enhancement New feature or request label Jul 7, 2020
@nikeee
Copy link
Owner

nikeee commented Jul 7, 2020

I changed the action to use an image that is automatically built from this repository. It should "just work" without any further configuration.

@nikeee nikeee closed this as completed Jul 7, 2020
@SeanKilleen
Copy link
Contributor Author

Beautiful, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants