Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docfx from v2.45.1 --> 2.56.1 #7

Merged
merged 1 commit into from Jul 12, 2020
Merged

Conversation

SeanKilleen
Copy link
Contributor

@SeanKilleen SeanKilleen commented Jul 10, 2020

Updates docfx to the lastest release.

I believe this version includes several bugfixes, one of which is related to nunit/docs#448.

@nikeee
Copy link
Owner

nikeee commented Jul 12, 2020

Thank you!

@nikeee
Copy link
Owner

nikeee commented Jul 12, 2020

A reference if something pops up: we hat some issues with newer versions of DocFX in #1. The solution then was downgrading.

@uweeby
Copy link

uweeby commented Jul 13, 2020

had to rollback to fix issue from latest. related? dotnet/docfx#5785

nikeee added a commit that referenced this pull request Jul 13, 2020
@nikeee
Copy link
Owner

nikeee commented Jul 13, 2020

We're back at 2.45.1 as long as dotnet/docfx#5785 isn't fixed.

@SeanKilleen
Copy link
Contributor Author

No worries, I was unaware of that issue.

I forked the project to make the updates since we're not impacted by that. In the future, I'll try to submit a PR where the docfx version can be parameterized and tagged separately so that releases of the tool across many docfx versions will be possible. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants