-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onConnect() does not indentify incorrect port usage #15
Comments
How would you handle this error? Would you rather emit an |
OK, after i wrote an essay XD here is my conclusion: |
wait, didn't you throwed an exception in case the connection could not be established?! |
Currently, there is no Edit: I see, there is a promise rejection in the beginning of You might want to look at 4776399 to see if it fits what you need. Haven't tested it. Despite that, I personally think that this library needs a re-write. However, this won't happen in the near future. |
The function onConnect does not recognize a foreign telnet service. In case you provide the Port of another telnet service as a parameter to establish the connection to (e.g mailserver ("220 Welcome(\n)")), The function emits ("correctly") an connect.
Every/most further communication aka send() will appear correct.
Imho there should either be a possibilty to check the first answer
("TS3\nWelcome to the TeamSpeak 3 ServerQuery interface, type "help" for a list of commands and "help <command>" for information on a specific command.")
myself or the function should proof that it is a correct servicepartner instead of ignoring the "two first lines sent by server ("TS3" and information message)"node-ts.js:42
node-ts.js:51 ff.
The text was updated successfully, but these errors were encountered: