-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solve the test errors #8
base: master
Are you sure you want to change the base?
Conversation
@@ -29,6 +31,7 @@ | |||
}, | |||
"devDependencies": { | |||
"@types/node": "^20.8.0", | |||
"pre-commit": "^1.2.2", | |||
"prettier": "^3.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a better solution for this. I'm going to put the node_modules and the build artifacts to a separate, orphaned dist
-branch, which will also receive the tags. This branch could be built by the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want me to remove all the pre-commit related statements then ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a second though, we have 2 options here:
- build the actions and push .js and node_module to dist (current)
- build on a CI branch that will be wired to the release
I agree solution 2 is better but as you mentioned it will be done in another PR.
So keep things working while you work on it, the pre-commit hook is the only guarantee to have consistently .ts and .js files aligned. In short I would argument in favor of keeping it until you create the extra CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance to see this PR updated? I would prefer to rely on your repository instead of my fix branch in the pydata-sphinx-theme.
Sorry for the very noisy PR but act is not able to locally emulate windows and mac runners so I was forced to push everything to here to check test success. here is a little summary on what this is doing:
act -j test