-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #162 #222
Fixes #162 #222
Conversation
Thanks for your PR! You're right #162 is a real mess. I tried to sort it out and added a comment which should give an overview. |
@MoritzKn Yeah, sorry for not including the repro.
I went through the stack trace, this line causes the error. I noticed that the As per the cause of this, I think Atom use to include a newline when getting buffer regions, this is no longer the case. |
Ok, thank you! Good research, I appreciate that. 😄 |
Released with version |
Thanks for the timely merge @MoritzKn! |
The regex wasn't matching the line. I think Atom use to includes newlines on to the beginning of text buffers, this is no longer the case. This fixes the
Wrap Lines
command.Ref #162
cc @MoritzKn
Edit: Actually, looks like due to Atom's reporting system, #162 is actually an accumulation of multiple errors, all with the same error message
Uncaught TypeError: Cannot read property '1' of null
- this PR will resolve the issues regarding the wrap lines function, but not all reported in that thread. The issue should remain open.