This repository has been archived by the owner on Aug 27, 2020. It is now read-only.
Bug fixes + enhanced font features #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
itsthatguy
commented
Dec 22, 2014
itsthatguy
commented
- Uses correct method to extract user configured settings
- Uses correct config declarations
- Replaces font-scale with font-size and line-height to make it easier to use
- Adds font-family setting to allow users to customize the feel
- Uses correct method to extract user configured settings - Replaces font-scale with font-size and line-height to make it easier to use - Adds font-family setting to allow users to customize the feel
| @@ -19,8 +19,9 @@ GitLogView.prototype.initialize = function(repo_name) { | |||
|
|
|||
| this.info_panel.hide(); | |||
| this.path = repo_name; | |||
| this.font_size = settings.editor.fontSize * settings['git-log'].fontScale; | |||
There was a problem hiding this comment.
You cannot extract settings this way
|
Just opened an issue for this (#42) and submitted an alternate solution (#43). I should have checked open PR's first. +1 on this PR: Font size was not being calculated properly because the settings API now uses @nikhilkalige, I leave the choice of which PR to merge up to you. Great work on the plugin! |
|
@komputerwiz Thank you... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.