This repository has been archived by the owner on Nov 20, 2022. It is now read-only.
Fixed curl example #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uv_poll_stop((uv_poll_t*) socketp); | ||
| uv_close((uv_handle_t*) socketp, (uv_close_cb) free); | ||
| uv_poll_stop(&((curl_context_t*)socketp)->poll_handle); | ||
| destroy_curl_context((curl_context_t*) socketp); |
| uv_close((uv_handle_t*) &context->poll_handle, curl_close_cb); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Indent this whole block to 4 spaces please.
|
Thanks for the correction, I'll have to be careful with the pointers, it bit me once, where I also made the mistake to notate it like Type* ptrX; and later on added another one, Type* ptrX, ptrY ;-) so: Type *ptrX is much better. I hope the code is now ok? You are more familiar with libuv, is this method fine? |
nikhilm
added a commit
that referenced
this pull request
Mar 28, 2013
Fixed curl example. Use struct rather than access platform specific internal fd field on uv_poll_t. Thanks to @clemensg
|
Thanks for the patch @clemensg! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Finally, I had time to try your suggestion. I did it according to the libuv poll test.
But see for yourself, it works on Windows, I hope I didn't break it on other systems and also, I hope I did not forget anything.
Thanks.
Best regards, Clemens