Rename resource plugin settings

nikhilsbhat · Dec 30, 2022 · c67b936 · c67b936
1 parent 861a98e
commit c67b936
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 25 deletions.
diff --git a/examples/json_plugins_setttings.tf b/examples/json_plugins_setttings.tf
@@ -1,4 +1,4 @@
-//resource "gocd_plugins" "json_plugin_settings" {
+//resource "gocd_plugin_setting" "json_plugin_settings" {
 //  plugin_id = "json.config.plugin"
 //  plugin_configurations {
 //    key   = "pipeline_pattern"

diff --git a/examples/yaml_plugins_setttings.tf b/examples/yaml_plugins_setttings.tf
@@ -1,11 +1,11 @@
-//resource "gocd_plugins" "yaml_plugin_settings" {
-//  plugin_id = "yaml.config.plugin"
-//  plugin_configurations {
-//    key   = "file_pattern"
-//    value = "*.gocd.yaml"
-//  }
-//  plugin_configurations {
-//    key   = "file_pattern"
-//    value = "*.gocd.yam"
-//  }
-//}
+resource "gocd_plugin_setting" "yaml_plugin_settings" {
+  plugin_id = "yaml.config.plugin"
+  plugin_configurations {
+    key   = "file_pattern"
+    value = "*.gocd.yaml"
+  }
+  plugin_configurations {
+    key   = "file_pattern"
+    value = "*.gocd.yam"
+  }
+}
diff --git a/gocd/cluster_profile.go b/gocd/cluster_profile.go
@@ -129,7 +129,7 @@ func resourceClusterProfileUpdate(ctx context.Context, d *schema.ResourceData, m
 				return diag.Errorf("updating cluster profile %s errored with: %v", cfg.ID, err)
 			}
 
-			return resourcePluginsRead(ctx, d, meta)
+			return resourceClusterProfileRead(ctx, d, meta)
 		}
 	}
 

diff --git a/gocd/provider.go b/gocd/provider.go
@@ -52,7 +52,7 @@ func Provider() *schema.Provider {
 		},
 
 		ResourcesMap: map[string]*schema.Resource{
-			"gocd_plugins":               resourcePlugins(),
+			"gocd_plugin_setting":        resourcePluginsSetting(),
 			"gocd_auth_config":           resourceAuthConfig(),
 			"gocd_cluster_profile":       clusterProfile(),
 			"gocd_elastic_agent_profile": elasticAgentProfile(),

diff --git a/gocd/resource_plugins.go → gocd/resource_plugin_settings.go b/gocd/resource_plugins.go → gocd/resource_plugin_settings.go
@@ -27,12 +27,12 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
 
-func resourcePlugins() *schema.Resource {
+func resourcePluginsSetting() *schema.Resource {
 	return &schema.Resource{
-		CreateContext: resourcePluginsCreate,
-		ReadContext:   resourcePluginsRead,
-		DeleteContext: resourcePluginsDelete,
-		UpdateContext: resourcePluginsUpdate,
+		CreateContext: resourcePluginsSettingsCreate,
+		ReadContext:   resourcePluginsSettingsRead,
+		DeleteContext: resourcePluginsSettingsDelete,
+		UpdateContext: resourcePluginsSettingsUpdate,
 		Schema: map[string]*schema.Schema{
 			"plugin_id": {
 				Type:        schema.TypeString,
@@ -82,7 +82,7 @@ func resourcePlugins() *schema.Resource {
 	}
 }
 
-func resourcePluginsCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func resourcePluginsSettingsCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	defaultConfig := meta.(gocd.GoCd)
 
 	if !d.IsNewResource() {
@@ -113,10 +113,10 @@ func resourcePluginsCreate(ctx context.Context, d *schema.ResourceData, meta int
 
 	d.SetId(id)
 
-	return resourcePluginsRead(ctx, d, meta)
+	return resourcePluginsSettingsRead(ctx, d, meta)
 }
 
-func resourcePluginsRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func resourcePluginsSettingsRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	defaultConfig := meta.(gocd.GoCd)
 
 	response, err := defaultConfig.GetPluginSettings(utils.String(d.Get(utils.TerraformPluginID)))
@@ -131,7 +131,7 @@ func resourcePluginsRead(ctx context.Context, d *schema.ResourceData, meta inter
 	return nil
 }
 
-func resourcePluginsUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func resourcePluginsSettingsUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	defaultConfig := meta.(gocd.GoCd)
 
 	if d.HasChange(utils.TerraformResourcePluginConfiguration) {
@@ -148,7 +148,7 @@ func resourcePluginsUpdate(ctx context.Context, d *schema.ResourceData, meta int
 				return diag.Errorf("updating plugin configuration errored with: %v", err)
 			}
 
-			return resourcePluginsRead(ctx, d, meta)
+			return resourcePluginsSettingsRead(ctx, d, meta)
 		}
 	}
 
@@ -157,7 +157,7 @@ func resourcePluginsUpdate(ctx context.Context, d *schema.ResourceData, meta int
 	return nil
 }
 
-func resourcePluginsDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func resourcePluginsSettingsDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	defaultConfig := meta.(gocd.GoCd)
 
 	if id := d.Id(); len(id) == 0 {