Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize production build by ignoring dev files #622

Merged
merged 1 commit into from Sep 18, 2019

Conversation

kylekatarnls
Copy link
Contributor

No description provided.

@carusogabriel
Copy link
Contributor

@kylekatarnls See #178 and the linked PRs.

@kylekatarnls
Copy link
Contributor Author

All those PRs show that the need of having a clean production package is more required than the need of having doc and tests in every vendor directories of the world. People who want it can use --prefer-source, please let users decide, don't force them to download files they don't use.

@carusogabriel
Copy link
Contributor

Interesting discussion about this topic in Symfony: symfony/symfony#33579

@nikic nikic merged commit 6032031 into nikic:master Sep 18, 2019
@nikic
Copy link
Owner

nikic commented Sep 18, 2019

Okay, you win :)

@kylekatarnls kylekatarnls deleted the patch-1 branch September 18, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants