Fix missing type annotations in AST nodes #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Sep 18, 2023
rainx
force-pushed
the
add-missing-type-annotations
branch
from
b0c4bc6
to
4399603
Compare
rainx
force-pushed
the
add-missing-type-annotations
branch
from
4399603
to
78c07af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After upgrading to v5.0.0, there were some missing type annotations in the AST nodes class which those types were correctly annotated in v4.x
What does this PR do
Add the missing types
Why did we find this issue?
I am working on a project that generates TypeScript type definition files for the PHP Parser dumped AST nodes(by
-joption of the CLI command). those types should be generated automatically through the PHP source code, it depends on the type annotation to infer the proper TS types.It works very well for v4. today, I tried to migrate it to v5. and when I rerun the
generatescript. I found the missing types.