Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception <class 'select.error'>: (4, 'Interrupted system call') after upgrading stompest #44

Closed
tobgu opened this issue Sep 19, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@tobgu
Copy link

tobgu commented Sep 19, 2017

After upgrading stompest from 2.1.6 to 2.3.0 I get 'Interrupted system call' whenever the application is waiting in canRead and I send a signal to the application.

I think this is due to the Python 3 updates here: 75c5692#diff-715c90981f31edb3e6e79120fa0c7e91L35

These types of exceptions were previously handled by stompest but I don't think that code is triggered anymore since if code == errno.EINTR is no longer true since code is no longer a number.

I'm running on Python 2.7.13.

@nikipore
Copy link
Owner

Thank you for your observation. Would you mind to contribute a fix, ideally including a test case (don't know whether mocking a signal is straightforward)?

@nikipore nikipore added the bug label Sep 19, 2017
@tobgu
Copy link
Author

tobgu commented Sep 22, 2017

I can give it a try. Is python 3.3 compatibility a must? (This is handled by Python itself starting from 3.5).

@nikipore
Copy link
Owner

All support for the 3.3 series of releases ends on 2017-09-29, five years after the initial release, so we might drop 3.3 compatibility, but not 3.4. Would that help? If so, please do not forget to update the package metadata accordingly.

@nikipore nikipore added this to the 2.3.1 milestone Sep 22, 2017
@tobgu
Copy link
Author

tobgu commented Sep 28, 2017

It doesn't really help if we cannot also drop 3.4 support. I made an implementation for all three cases though.

nikipore added a commit that referenced this issue Sep 28, 2017
Fix #44 proper identification of EINTR for all supported versions of …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants