Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excessive IDE dependencies #93

Closed
Privat33r-dev opened this issue May 1, 2024 · 0 comments · Fixed by #94
Closed

Remove excessive IDE dependencies #93

Privat33r-dev opened this issue May 1, 2024 · 0 comments · Fixed by #94

Comments

@Privat33r-dev
Copy link
Contributor

During discussion of #91 it was noted that current setup require developers to use yapf formatter and pylint plugins.

I suggest:

  1. Change formatter to black (with standard configuration) as it's more common.
  2. Remove pylint plugins since we won't need custom quote check if we are using black formatter.

After this the process for new contributors would be streamlined.
@Privat33r-dev Privat33r-dev mentioned this issue May 1, 2024
Merged
nikitastupin pushed a commit that referenced this issue May 3, 2024
@Privat33r-dev
GH-93: change formatter (#94)
c1cf195 
* Change formatter from yapf to black

Yapf is uncommon formatter,
requiring it makes process of onboarding new contributors harder.

Yapf with non-standard configuration as well introduces less common coding style,
which might slightly confuse some developers.

Black with standard configuration is the most popular formatting tool.

* Replace yapf with black in dependencies

Remove plugins
Update poetry.lock
nikitastupin added a commit that referenced this issue May 3, 2024
@nikitastupin
change yapf to black (#93) and format
2c28c8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-93: change formatter Privat33r-dev/clairvoyance
1 participant
@Privat33r-dev