Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent compile error if /priv/static/svg doesn't exist #6

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Prevent compile error if /priv/static/svg doesn't exist #6

merged 2 commits into from
Nov 29, 2017

Conversation

johantell
Copy link
Contributor

If /priv/static/svg doesn't exist the compile step causes an error preventing a lot of things from happening.

This fix will prevent that error and instead "fail" silently by not creating cached methods for assets

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 2c854e2 on mintcore:fix/compile_error_on_missing_folder into f025f57 on nikkomiu:master.

@johantell
Copy link
Contributor Author

johantell commented Nov 28, 2017

Credo doesn't seem to like that extra level the case statement adds. As I cannot get past that without refactoring. Would it be ok if i refactored the __using__ method and extracted some things?

@nikkomiu
Copy link
Owner

Thanks for the pull request!

I think it would look a lot better with a refactor of __using__ it is getting pretty deep with the added case.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling c1b7b58 on mintcore:fix/compile_error_on_missing_folder into f025f57 on nikkomiu:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 8a3532a on mintcore:fix/compile_error_on_missing_folder into f025f57 on nikkomiu:master.

@johantell
Copy link
Contributor Author

Would that be good enough?

@nikkomiu
Copy link
Owner

I want to double check that splitting this into multiple functions isn't going to break releases with Distillery before merging.

I think at one point I tried to split it into multiple functions and the result was the caching part didn't actually work.

@nikkomiu nikkomiu merged commit 484d964 into nikkomiu:master Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants