Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for append html attributes #7

Merged

Conversation

joaovitoras
Copy link
Contributor

@joaovitoras joaovitoras commented May 15, 2018

Inspired by ruby inline_svg my intention is to make possible add html attributes in the svg found and allow it to be possible to make other modifications to the svg

  • Changes docs to ExDoc styles
    • Fixes html svg syntax hightlighting
  • Adds support for options in svg_image function
  • Makes id and class available options

Todo:

  • Tests

WIP

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 3cf98f8 on quero-edu:adds-support-for-append-html-attributes into 22b46e2 on nikkomiu:master.

@nikkomiu
Copy link
Owner

Why did you remove the markdown syntax for the code blocks from the docs?

@joaovitoras
Copy link
Contributor Author

I've changed the default way of blocking syntax from ExDoc code. It supports markdown syntax but for elixir code it already identifies by default, I just made explicit the ones that really need like html in the svg block.
Do you prefer to make everything explicit? I can reverse it if it's better.

@nikkomiu
Copy link
Owner

Awesome, I didn't realize there was an implicit for Elixir.

@nikkomiu nikkomiu merged commit 0b2cd0f into nikkomiu:master May 17, 2018
@nikkomiu
Copy link
Owner

v1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants