Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve merge rules for setups without branch protection #4

Closed
2 tasks
nikku opened this issue Nov 27, 2018 · 0 comments
Closed
2 tasks

Improve merge rules for setups without branch protection #4

nikku opened this issue Nov 27, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@nikku
Copy link
Owner

nikku commented Nov 27, 2018

We already require at least a single review for external pull requests. It is probably safe to say that this should be the default behavior for any kind of collaborative project.

Tasks

If no branch protection is configured...

  • Require at least a single approved review before merging
  • Block merging, if a review rejects the changes
@nikku nikku added the enhancement New feature or request label Nov 27, 2018
nikku added a commit that referenced this issue Nov 27, 2018
@nikku
feat(project): improve merge without branch protection
7443749 
* rewrite core
* if base branch is protected, skip branch checks and let
  GitHub do the job
* always require at least a single human review before merging

Closes #4
@nikku nikku closed this as completed in 7bd52b9 Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikku