Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only skip unparseable attributes #13

Closed
nikku opened this issue Mar 11, 2018 · 0 comments
Closed

Only skip unparseable attributes #13

nikku opened this issue Mar 11, 2018 · 0 comments
Labels
enhancement

Comments

@nikku
Copy link
Owner

nikku commented Mar 11, 2018

Some attribute parse errors are recoverable such as

  • illegal first char attribute name
  • attribute value missing

We not recover from these rather than rejecting the whole attribute list.
nikku added a commit that referenced this issue Mar 11, 2018
@nikku
test(attrs): failing test case for improved attribute parsing
b38b80a 
[ci skip]

Related to #13
nikku added a commit that referenced this issue Mar 18, 2018
@nikku
feat(parser): recover from attribute parse errors
bbd1027 
Closes #13
nikku added a commit that referenced this issue Mar 18, 2018
@nikku
test(attrs): failing test case for improved attribute parsing
32e90fb 
[ci skip]

Related to #13
@nikku nikku closed this as completed in 33682c7 Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikku