This repository has been archived by the owner on Dec 9, 2018. It is now read-only.
Added dryscrape.stop_xvfb() function #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you mean to include the .egg-info directory? I don't think it should be part of the repository |
|
No I didn't mean to do that :( |
|
Great :) Thanks for the idea and for implementing it! |
|
So do I close this pull request and just submit a new one? |
niklasb
added a commit
that referenced
this pull request
Aug 21, 2015
Added dryscrape.stop_xvfb() function
|
Thanks. No you don't need to open a new pull request, the old one is updated automatically as you push into the same branch. |
|
Ahh ok. I see now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be useful when using dryscrape in a python console or if dryscrape is only needed in a small portion of an application thus requiring an explicit stop function.