Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling of 'Repetition?' #20

Closed
mixographer opened this issue Apr 14, 2015 · 2 comments
Closed

Spelling of 'Repetition?' #20

mixographer opened this issue Apr 14, 2015 · 2 comments

Comments

@mixographer
Copy link

Hi Niklasf,

I don't know if it matters, or if you can spell the class both ways in future, but I think repitition is spelled repetition. A pull-request in picochess was broken because the requestor spelled repitition the correct way. I don't know what the right answer is, since the correct way was a typo since it's not the name of the method. Just an FYI. Anyway, thanks for python-chess.

Jimmy

@niklasf
Copy link
Owner

niklasf commented Apr 14, 2015

Hi Jimmy,

thanks for reporting this. I would have never noticed, believing it was actually spelled that way and doing it consistently all over the place.

I fixed the spelling. The next release will include can_claim_threefold_repetition and is_fivefold_repetition but also aliases with the incorrect spelling.

The release after that will have those aliases removed. I'll mention it in the changelog again.

Niklas

@mixographer
Copy link
Author

I will let djdekker know that at some point the current spelling will be deprecated. I hope the changes don't cause problems downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants