Code blocks with blank lines around the content are not handled correctly

[daviwil]

Hi all!

I've experienced an issue with org-mode file rendering on Codeberg and I found that they use your library for writing out HTML from Org files. The issue is that when one has a code block like this in an Org file:

#+begin_src sh

  guix pull

#+end_src

The output looks like this on your demo site:

Notice that there seems to be a blank line above the line guix pull but not after it, making the padding of the code block look strange. You can see a real-world example of this issue here:

https://codeberg.org/SystemCrafters/crafted-guix#headline-3

Is there any way you could trim empty lines before and after the actual content of a begin_src block while still retaining any indentation in lines that contain real content? I think that would help make code block rendering look more consistent for a wider variety of Org files.

It appears that blocks.org does not have any examples with spacing like this, so it seems to be an untested scenario.

Thanks a lot!

[daviwil]

It looks like this line needs to be expanded to do left-side trimming without eating leading whitespace on the first real line:

go-org/org/html_writer.go

Line 625 in 2d45490

return strings.TrimRightFunc(out, unicode.IsSpace)

Thanks @yantar92 for finding that!

[niklasfasching]

thx everyone. will tag a release for codeberg to update to
early next week!

[daviwil]

Awesome, thanks a bunch @niklasfasching and super thanks to @FikriRNurhidayat for the fix!