Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applying text-shadow is generating incorrect screenshot #1638

Closed
kcak11 opened this issue Aug 24, 2018 · 4 comments
Closed

applying text-shadow is generating incorrect screenshot #1638

kcak11 opened this issue Aug 24, 2018 · 4 comments

Comments

@kcak11
Copy link

kcak11 commented Aug 24, 2018

Bug reports:

Applying text-shadow on a element is also applying text-shadow and box-shadow for other elements on the page. See attached PDF file.

Page 1 describes the real page, and Page 2 shows the generated screenshot.

Issues noticed in the Screenshot:

  • Issue 1: All the text elements on the page have text-shadow applied.
  • Issue 2: All the elements with a border also have the box-shadow applied.

Attachment:
buggy_screenshot.pdf

Specifications:

This was referenced Sep 10, 2018
@kcak11
Copy link
Author

kcak11 commented Sep 10, 2018

Pull Request for the current issue: #1653
waiting for merge . . .

niklasvh added a commit that referenced this issue Apr 8, 2019
* Fix for Issue-1638 (#1638)
Resolution: Clearing the Shadow Properties after they are consumed
@niklasvh
Copy link
Owner

niklasvh commented Apr 8, 2019

Fix merged with #1795

@niklasvh niklasvh closed this as completed Apr 8, 2019
@kcak11
Copy link
Author

kcak11 commented Apr 8, 2019

Fix merged with #1795

Thanks !!

@vincentcox
Copy link

@niklasvh Is this fix also expandable to this issue? #1622

It's box-shadow, so I don't know if it's the same method you used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants