-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working for webkit-filter #493
Comments
css filter's haven't been implemented |
I am also waiting for filters to be implemented, @niklasvh any idea if we could do it by ourselves? Regards |
+1. I'm waiting too |
What about this new feature? |
+1. I'm waiting too |
Me too, expecting -webkit-filter:blur() work, thank you. |
+1. waiting too |
+1 |
1 similar comment
+1 |
+1 |
3 similar comments
+1 |
+1 |
+1 |
I wrote a tiny library that could screenshot the image along with the css filter properties, hope it helps |
great |
I added basic filter support into html to canvas. |
Updates? |
fix #2300 |
Lately I've been converting Flash based web apps to HTML5/CSS and JavaScript. I've been using html2canvas to capture the HTML elements and converting them into images. Only problem I've been having is that it does not support filters and webkitTextStroke . I've been trying @ysk2014 #2300 fix, but it doesn't produce good results with webkitTextStroke and filters doesn't seem to be supported at all. I've tested with the Blur filter and the Shadow filter. |
@istoan Can you provide some examples of not working? All the examples I wrote are in the tests folder:
|
@ysk2014 I may not have the right html2canvas version. Where can I find a compiled version with support for filters and stroke? Is there a way to download a html2canvas.js file? |
@istoan you can git clone git@github.com:ysk2014/html2canvas.git and run npm start |
I managed to clone that after installing the Git Desktop app. I then opened the folder with VS Code and opened Terminal inside VS Code. Then I typed: npm start and I got the following error:
What am I doing wrong? And, is there an easier way to get a compiled version? Can you upload one to your repository? |
@ysk2014 I'm new to this. I believe I first had to install all the dependencies needed. I did npm install and got all of them. I then typed npm start and I got:
But it seems I can't find a html2canvas.js file. Not sure how to actually compile one so I can use it in my project. |
@istoan Run npm run build. A dist folder will be generated with the JS file you want |
@ysk2014 I managed to compile the file and the results seem to be the same as with the other html2canvas.js file downloaded from https://github.com/niklasvh/html2canvas/suites/1187063696/artifacts/17429870 This is how it looks inside my HTML page: This is the results produced with the new html2canvas.js code: Am I missing something? Are there some special arguments I need to add? Right now I use:
|
@istoan Can you provide the code? It's easy for me to find problems. |
@ysk2014 An example can be found here: And the files for that example are attached |
@istoan Sorry. Filter only supports img at present |
@ysk2014 Oh, that's why I got those results. Do you know any library that can save an image from HTML elements with filters applied? I really need a solution for this in order to deliver the functionality my app had inside the old Flash based version. |
@istoan You can try dom-to-image. In fact, html2canvas can also be implemented, but the compatibility is not good |
@ysk2014 Thank you very much! dom-to-image works as it should. You are a life saver! |
Any updates to this? dom-to-image is sadly not working well in my case. Html2canvas does everything correctly, the only problem is the filter |
+1 |
I would also appreciate very much this feature :) |
+1 |
1 similar comment
+1 |
For people looking for a solution that doesn't uses dom-to-image, i managed to make what i wanted by using Jimp. |
I have the same problem, the filter brightness() dosen't work. |
I'm using webkit brightness effect on canvas but while converting that canvas into new canvas these effects are not applied..
-webkit-filter: brightness(1.3);
-moz-filter: brightness(1.3);
The text was updated successfully, but these errors were encountered: