Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2299 and #2296 and #2009 and #493 #2300

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ysk2014
Copy link

@ysk2014 ysk2014 commented Jul 27, 2020

Summary

This PR fixes/implements the following bugs/features

  • Bug 1: opacity
  • Feature 1: text-stroke
  • Feature 2: css filter - only supports img at present
  • Feature 3: font color gradient - support left、right、bottom、top

@ysk2014
Copy link
Author

ysk2014 commented Jul 28, 2020

I think opacity is an attribute that can affect child elements and should be placed in effects

@ysk2014 ysk2014 changed the title fix #2299 and #2296 fix #2299 and #2296 and #2009 Aug 26, 2020
@ysk2014 ysk2014 changed the title fix #2299 and #2296 and #2009 fix #2299 and #2296 and #2009 and #493 Sep 1, 2020
@uinstinct
Copy link

I wonder why this pull request is not merged.

@nurulalamador
Copy link

Can you make a build release I mean a single .js file like html2canvas.js of this please?

@kizivat
Copy link

kizivat commented Oct 7, 2020

Can you make a build release I mean a single .js file like html2canvas.js of this please?

You can download the artifacts from the CI routine. However, here you go: https://github.com/niklasvh/html2canvas/suites/1187063696/artifacts/17429870 :)

@nurulalamador
Copy link

Can you make a build release I mean a single .js file like html2canvas.js of this please?

You can download the artifacts from the CI routine. However, here you go: https://github.com/niklasvh/html2canvas/suites/1187063696/artifacts/17429870 :)

Thank you very much for your help.

@ysk2014
Copy link
Author

ysk2014 commented Oct 15, 2020

FYI, @niklasvh

@horseson2018
Copy link

大佬你解决了opacity的bug吗

@ysk2014
Copy link
Author

ysk2014 commented Dec 30, 2020

大佬你解决了opacity的bug吗

解决了。你可以试试;不行可以找我

@horseson2018
Copy link

大佬你解决了opacity的bug吗

解决了。你可以试试;不行可以找我

确实解决了,谢谢大佬。还有个下划线和删除线的粗细bug大佬了解吗

chiisama14 added a commit to chiisama14/html2canvas that referenced this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants