Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for background-origin: content-box, fixed background-origin related background sizes #1299

Merged
merged 1 commit into from Dec 9, 2017

Conversation

matthias-christen
Copy link
Contributor

Summary

This PR fixes/implements the following bugs/features

  • Bug: When using background-origin and background-size: cover/contain, the background size was not calculated correctly.
  • Feature: Added support for background-origin: content-box

Explain the motivation for making this change. What existing problem does the pull request solve?

Add support for background-origin: content-box and fix for problem related to background image size with background-origin set to padding-box or content-box and background-size set to cover/contain.

Test plan (required)

Added tests/reftests/background/origin.html.

Code formatting

Please make sure that code adheres to the project code formatting. Running npm run format will automatically format your code correctly.

@niklasvh niklasvh merged commit 850338a into niklasvh:master Dec 9, 2017
@niklasvh
Copy link
Owner

niklasvh commented Dec 9, 2017

Thanks for the PR! I fixed the test and refactored the code a bit.

@matthias-christen
Copy link
Contributor Author

Thanks for the great project and for merging the PR so quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants