Quick fix for proxy for v0.5 #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy in v0.5 seems broken. I managed to load a cross-domain image by doing those changes. html2canvas.proxy was not defined and the response returned from the html2canvas PHP proxy was returning the result including the data type.
This was referenced Mar 19, 2015
|
Hey, will this fix be integrated anytime soon? |
|
@Rookev Probably not, this repo seems dead. There are 62 open pull requests... |
|
@Cristy94 this is already in "master"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy in v0.5 seems broken. I managed to load a cross-domain image by
doing those changes. html2canvas.proxy was not defined and the response
returned from the html2canvas PHP proxy was returning the result
including the data type.