works

README.md

@@ -5,6 +5,23 @@
 > As in newspaper articles, we expect the most important concepts to come first, and we expect them to be expressed with the least amount of polluting detail. We expect the low-level details to come last. This allows us to skim source files, getting the gist from the frist few functions, without having to immerge ourselves in the details.  
 > — Clean Code, Chapter 5, p84, Robert C. Martin, 2009
 
+![](./doc/code-dep-viz.png)
+
+```go
+go install github.com/nikolaydubina/verfn@latest
+```
+
+```bash
+verfn --verbose ./...
+```
+
+## False Positives
+
+ * same function names but different classes
+ * same functino names but from different packages
+ * functions passed as arguments
+ * functions passed as arguments and renamed to match existing functions 
+
 ## Appendix A: Canonical Java Example
 
 Clean Code, Chapter 5, code example `WikiPageResponder.java`

analysis/vertfn/analyzer.go

@@ -32,19 +32,19 @@ func init() {
 
 func fnameFromFuncDecl(n *ast.FuncDecl) string { return n.Name.Name }
 
-func fnameFromCallExpr(n *ast.CallExpr) string {
+func fnameFromCallExpr(n *ast.CallExpr) []string {
 	if ind, ok := n.Fun.(*ast.Ident); ok && ind != nil {
-		return ind.Name
+		return []string{ind.Name}
 	}
 	if sel, ok := n.Fun.(*ast.SelectorExpr); ok && sel != nil {
-		// TODO: utilize type/package information
-		// TODO: differentiate same method name but on different classes
-
-		// TODO: chains of selectors
-		// TODO: chains of methods
-		fmt.Printf("%#v | %#v\n", sel.X, sel.Sel)
+		var fnames []string
+		fnames = append(fnames, sel.Sel.Name)
+		if call, ok := sel.X.(*ast.CallExpr); ok && call != nil {
+			fnames = append(fnames, fnameFromCallExpr(call)...)
+		}
+		return fnames
 	}
-	return ""
+	return nil
 }
 
 func run(pass *analysis.Pass) (interface{}, error) {
@@ -72,7 +72,9 @@ func run(pass *analysis.Pass) (interface{}, error) {
 		}
 
 		if call, ok := n.(*ast.CallExpr); ok && call != nil {
-			fnCall[fnameFromCallExpr(call)] = append(fnCall[fnameFromCallExpr(call)], call)
+			for _, fname := range fnameFromCallExpr(call) {
+				fnCall[fname] = append(fnCall[fname], call)
+			}
 		}
 	})
 

analysis/vertfn/internal/example/simple.go

@@ -12,20 +12,30 @@ func mixFlour() {
 }
 
 func MakePancake() {
+	readRecipe()
+
 	visitStore()
 
 	mixFlour()
 
-	FindOven().WarmUp().Bake()
+	FindOven().
+		WarmUp().
+		WarmUp().
+		Bake()
 
 	Enjoy("pancake")
 }
 
+func readRecipe() {
+	log.Println("reading recepie")
+}
+
 func buyFlour() {
 	log.Println("bought flour")
 }
 
 func visitStore() {
+	readRecipe()
 	buyFlour()
 }