Skip to content
This repository has been archived by the owner on Oct 11, 2020. It is now read-only.

Inline YouTube videos are blocked on some sites #76

Closed
nicole-ashley opened this issue Apr 18, 2017 · 14 comments
Closed

Inline YouTube videos are blocked on some sites #76

nicole-ashley opened this issue Apr 18, 2017 · 14 comments

Comments

@nicole-ashley
Copy link
Owner

nicole-ashley commented Apr 18, 2017

Describe the issue

On some sites, eg Windows Central, inline YouTube videos are blocked by a child-src http: CSP header.

One or more specific URLs where the issue occurs

http://www.windowscentral.com/askdanwindows-23

Screenshot in which the issue can be seen

Edge:
image

Chrome:
image

Steps for anyone to reproduce the issue

  1. Enable uBlock
  2. Browse to http://www.windowscentral.com/askdanwindows-23. Videos are missing.
  3. Disable uBlock
  4. Refresh the page. Videos are present.

Your settings

Default.

  • OS/version: Microsoft Windows [Version 10.0.16176]
  • Browser/version: 40.16176.1000.0
  • uBlock Origin version: 1.12.1.0
Your filter lists

Default

Your custom filters (if any)
@gorhill
Copy link

gorhill commented Apr 18, 2017

It's the |blob:$domain=1337x.to|1channel.biz|ancient-origins.net|androidcentral.com|anime-joy.tv|... filter in EasyList which causes this. The exception filter @@|blob:$domain=windowscentral.com can be used to work around the issue.

Given the site works fine with Chrome/Firefox without the need for the exception filter, I gather this is an issue with Edge?

@nicole-ashley
Copy link
Owner Author

nicole-ashley commented May 1, 2017

@gorhill: Ok, it took me a little while to track down because I was a bit confused as to how Chrome and Firefox were allowing https: URLs when the CSP only specified http:. But then I found the information regarding this in the CSP3 draft change list: http://www.w3.org/TR/CSP3/#changes-from-level-2

So it looks like Chrome and Firefox are running according to the draft and Edge hasn't released any work on it yet.

A solution is to change the child-src http: directive to child-src http: https: which works for me on the above URL. If you didn't want to put this tweak in Core then I could add it as a transformation in the Edge build process.

Edit: removed bit about merging CSP lists because uBlock doesn't actually do that.

@nicole-ashley
Copy link
Owner Author

@scottlow FYI.

@gorhill
Copy link

gorhill commented May 1, 2017

A solution is to change the child-src http: directive to child-src http: https: which works for me on the above URL.

Coincidentally this is something I changed in this commit: gorhill@3ce3ed2, part of 1.12.3b1

@nicole-ashley
Copy link
Owner Author

Ah, ideal! Thanks @gorhill, nice and easy.

@AdamDotNet
Copy link

@nikrolls I tried gorhill's @@|blob:$domain=windowscentral.com and the youtube iframes load, but then the video ultimately has a playback error. Turning off uBlock to see if the video can play without errors works. Are you seeing that too? Either way, I'm subscribed to this thread to see when a new build pulls in the CSP fix mentioned above, so I'd be wait and see once that's in.

Example: https://www.windowscentral.com/hands-surface-laptop

Image I'm seeing:
youtube playback error

Edge HTML 15 from the Windows 10 Creators Update (stable).

uBlock version 1.12.1.

@nicole-ashley
Copy link
Owner Author

Hi @AdamDotNet, do you have large media element blocking turned on?

@AdamDotNet
Copy link

Settings page under default behavior, right?
"Block media elements larger than x kB" is not checked.

Filter lists checked:

uBlock Filters
uBlock Filters - Badware risks
uBlock Filters - privacy
uBlock Filters - Unbreak

Adblock protector list
Adblock warning removal list
Anti-Adblock Killer | Reek
Easylist

EasyPrivacy

Malware Domain List
Malware domains
Peter Lowe's Ad and tracking server list

My filters

windowscentral.com##.mn_mbn_share
@@|blob:$domain=windowscentral.com

@nicole-ashley
Copy link
Owner Author

@nicole-ashley
Copy link
Owner Author

I'll check for your issue @AdamDotNet and create a new ticket shortly if I can reproduce it.

@cdayo
Copy link

cdayo commented May 17, 2017

Hi @nikrolls , with 1.12.4 I'm actually getting the error that @AdamDotNet was describing! It happened on any of the windowscentral embedded videos. Now I can't seem to get past the pesky Admiral anti-adblock they have on that site - any thoughts on how to get around this?

@gorhill
Copy link

gorhill commented May 17, 2017

any thoughts on how to get around this?

Force an update of uBlock filters.

@cdayo
Copy link

cdayo commented May 17, 2017

Ah, that did the trick. Thank you! Now I can happily reproduce @AdamDotNet 's issue! Happening on a different link as below: http://www.windowscentral.com/why-windows-s-and-project-centennial-are-important-continuums-success

image

@cdayo
Copy link

cdayo commented Jul 27, 2017

@nikrolls This still occurs in 1.13.8.0... why issue closed? :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants