Use config for upload directory and media cache directory in Media

controller. Prepare movin index.php to public. Cope with #72

Add PHPUnit test. Keep going with PHPUnit or try to make same tests
with Atoum ?

.github/workflows/phyxo.yml

@@ -58,6 +58,9 @@ jobs:
       - name: Unit tests
         run: ./bin/atoum
 
+      - name: PHPUnit tests
+        run: ./bin/simple-phpunit --testdox
+
       - name: Create database
         run: ./bin/console doctrine:database:create -vvv
 

.gitignore

@@ -71,3 +71,12 @@ behat.yml
 /.php_cs.cache
 ###< friendsofphp/php-cs-fixer ###
 /install/queries.sql
+
+/tests/media
+/tests/upload
+
+###> symfony/phpunit-bridge ###
+.phpunit
+.phpunit.result.cache
+/phpunit.xml
+###< symfony/phpunit-bridge ###

composer.json

@@ -48,9 +48,11 @@
         "phpstan/extension-installer": "^1.0",
         "phpstan/phpstan": "^0.12.42",
         "phpstan/phpstan-doctrine": "^0.12.19",
+        "symfony/browser-kit": "^4.4",
+        "symfony/css-selector": "^4.4",
         "symfony/maker-bundle": "^1.21",
-        "symfony/profiler-pack": "^1.0",
-        "symfony/test-pack": "^1.0"
+        "symfony/phpunit-bridge": "^5.2",
+        "symfony/profiler-pack": "^1.0"
     },
     "config": {
 	"preferred-install": {

config/parameters_test.yaml

@@ -0,0 +1,3 @@
+parameters:
+    upload_dir: '%kernel.project_dir%/tests/upload'
+    media_cache_dir: '%kernel.project_dir%/tests/media'

config/services_test.yaml

@@ -1,3 +1,6 @@
+imports:
+  - { resource: parameters_test.yaml }
+
 services:
   _defaults:
     autowire: true
@@ -29,3 +32,6 @@ services:
 
   phyxo.comment.mapper:
     alias: 'App\DataMapper\CommentMapper'
+
+  phyxo.image.repository:
+    alias: 'App\Repository\ImageRepository'

features/web/media.feature

@@ -0,0 +1,28 @@
+Feature: Image
+  In order to discover the gallery
+  As a user
+  I need to be able to show images in differents size
+
+  Background: init
+    Given a user:
+      | username | password | status |
+      | user1    | pass1    | normal |
+
+    And an album:
+      | name      | status  |
+      | album 1   | public  |
+
+    And an image:
+      | name        | album     |
+      | photo 1.1   | album 1   |
+
+
+  Scenario: See images
+    Given I am logged in as "user1" with password "pass1"
+    And I follow "album 1"
+    And I follow "photo 1"
+    And I follow image of type "small"
+    Then the response status code should be 200
+
+
+

include/config_default.inc.php

@@ -430,16 +430,6 @@
 // Every plugin from 1.7 would be design to manage light_slideshow case.
 $conf['light_slideshow'] = true;
 
-// the local data directory is used to store data such as compiled templates,
-// plugin variables, or resized images. Beware of
-// mandatory trailing slash.
-$conf['data_location'] = '_data/';
-
-// where should the API/UploadForm add photos? This path must be relative to
-// the Phyxo installation directory (but can be outside, as long as it's
-// reachable from your webserver).
-$conf['upload_dir'] = './upload';
-
 // enable the synchronization method for adding photos
 $conf['enable_synchronization'] = false;
 

phpunit.xml.dist

@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!-- https://phpunit.readthedocs.io/en/latest/configuration.html -->
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="bin/.phpunit/phpunit.xsd"
+         backupGlobals="false"
+         colors="true"
+         bootstrap="config/bootstrap.php"
+>
+    <php>
+        <ini name="error_reporting" value="-1" />
+        <server name="APP_ENV" value="test" force="true" />
+        <server name="SHELL_VERBOSITY" value="-1" />
+        <server name="SYMFONY_PHPUNIT_REMOVE" value="" />
+        <server name="SYMFONY_PHPUNIT_VERSION" value="8.5" />
+    </php>
+
+    <testsuites>
+        <testsuite name="Project Test Suite">
+            <directory>tests</directory>
+        </testsuite>
+    </testsuites>
+
+    <filter>
+        <whitelist processUncoveredFilesFromWhitelist="true">
+            <directory suffix=".php">src</directory>
+        </whitelist>
+    </filter>
+
+    <listeners>
+        <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
+    </listeners>
+
+    <!-- Run `composer require symfony/panther` before enabling this extension -->
+    <!--
+    <extensions>
+        <extension class="Symfony\Component\Panther\ServerExtension" />
+    </extensions>
+    -->
+</phpunit>