Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS as a default scheme #10

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Use HTTPS as a default scheme #10

merged 1 commit into from
Oct 31, 2018

Conversation

DominikSerafin
Copy link
Contributor

HTTP was a good default some time ago. But now most of the websites are moving to HTTPS and also modern browsers like Chrome, Firefox, Edge, Opera, etc. are defaulting urls without scheme to HTTPS (e.g. "//example.com" will get defaulted to "https://example.com"). So I think it makes more sense now to use HTTPS instead HTTP as a default.

HTTP was a good default some time ago. But now most of the websites are moving to HTTPS and also modern browsers like Chrome, Firefox, Edge, Opera, etc. are defaulting urls without scheme to HTTPS (e.g. "//example.com" will get defaulted to "https://example.com"). So I think it makes more sense now to use HTTPS instead HTTP as a default.
@niksite niksite merged commit e144500 into niksite:master Oct 31, 2018
@sebix
Copy link

sebix commented Dec 6, 2018

Are you aware that this breaks/broke backwards-compatibility?

@DominikSerafin
Copy link
Contributor Author

@niksite @sebix let's bump the version to 2.X?

@niksite
Copy link
Owner

niksite commented Dec 13, 2018

Just released new version with support for default_scheme parameter. So, to use http scheme by default we can use url_normalize('//some/site', default_scheme='http').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants