r.watershed: Keep 0 accumulation with -a as 0 as opposed to null (OSG…

…eo#2169) * r.watershed: Keep 0 accumulation with -a as 0 as opposed to null * apply the same change to seg
nilason · Nov 7, 2023 · 97b2ed4 · 97b2ed4
1 parent ac1cfa1
commit 97b2ed4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 23 deletions.
diff --git a/raster/r.watershed/ram/close_maps.c b/raster/r.watershed/ram/close_maps.c
@@ -34,34 +34,24 @@ int close_maps(void)
 	    G_message("Writing out only positive flow accumulation values.");
 	    G_message
 		("Cells with a likely underestimate for flow accumulation can no longer be identified.");
-	    for (r = 0; r < nrows; r++) {
-		Rast_set_d_null_value(dbuf, ncols);	/* reset row to all NULL */
-		for (c = 0; c < ncols; c++) {
-		    dvalue = wat[SEG_INDEX(wat_seg, r, c)];
-		    if (Rast_is_d_null_value(&dvalue) == 0 && dvalue) {
-			dvalue = ABS(dvalue);
-			dbuf[c] = dvalue;
-			sum += dvalue;
-			sum_sqr += dvalue * dvalue;
-		    }
-		}
-		Rast_put_row(fd, dbuf, DCELL_TYPE);
-	    }
 	}
-	else {
-	    for (r = 0; r < nrows; r++) {
-		Rast_set_d_null_value(dbuf, ncols);	/* reset row to all NULL */
-		for (c = 0; c < ncols; c++) {
-		    dvalue = wat[SEG_INDEX(wat_seg, r, c)];
-		    if (!Rast_is_d_null_value(&dvalue)) {
-			dbuf[c] = dvalue;
+	for (r = 0; r < nrows; r++) {
+	    Rast_set_d_null_value(dbuf, ncols);	/* reset row to all NULL */
+	    for (c = 0; c < ncols; c++) {
+		dvalue = wat[SEG_INDEX(wat_seg, r, c)];
+		if (!Rast_is_d_null_value(&dvalue)) {
+		    if (abs_acc) {
 			dvalue = ABS(dvalue);
 			sum += dvalue;
-			sum_sqr += dvalue * dvalue;
 		    }
+		    else
+			sum += ABS(dvalue);
+
+		    dbuf[c] = dvalue;
+		    sum_sqr += dvalue * dvalue;
 		}
-		Rast_put_row(fd, dbuf, DCELL_TYPE);
 	    }
+	    Rast_put_row(fd, dbuf, DCELL_TYPE);
 	}
 	Rast_close(fd);
 

diff --git a/raster/r.watershed/seg/close_maps.c b/raster/r.watershed/seg/close_maps.c
@@ -40,7 +40,7 @@ int close_maps(void)
 	    for (c = 0; c < ncols; c++) {
 		/* dseg_get(&wat, &dvalue, r, c); */
 		dvalue = wabuf[c].wat;
-		if (Rast_is_d_null_value(&dvalue) == 0 && dvalue) {
+		if (!Rast_is_d_null_value(&dvalue)) {
 		    if (abs_acc) {
 			dvalue = fabs(dvalue);
 			sum += dvalue;