Skip to content

Commit

Permalink
[REL] add tags to changelog (#4012)
Browse files Browse the repository at this point in the history
* add tags

* add more badges

* finish updating changelog

* reorganize contributing

* fix typo

* Update CONTRIBUTING.rst

Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>

---------

Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
  • Loading branch information
Remi-Gau and ymzayek committed Sep 28, 2023
1 parent 5d7f5c6 commit 8090e3f
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 45 deletions.
17 changes: 15 additions & 2 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -257,14 +257,27 @@ Changelog entries in ``doc/changes/latest.rst`` should adhere to the following c

- Entry in the appropriate category
- Single line per entry
- Add a "badge" corresponding to the change type (see below)
- Finish with a link to the PR and the author's profile
- New contributors to add their details to the ``authors`` section of the ``CITATION.cff``
- New contributors to add their details to the ``authors`` section of the ``CITATION.cff`` (see below)

List of badges:

.. code-block:: rst
:bdg-primary:`Doc`
:bdg-secondary:`Maint`
:bdg-success:`API`
:bdg-info:`Plotting`
:bdg-warning:`Test`
:bdg-danger:`Deprecation`
:bdg-dark:`Code`
Example entry in ``doc/changes/latest.rst``:

.. code-block:: rst
- Fix off-by-one error when setting ticks in :func:`~plotting.plot_surf` (:gh:`3105` by `Dimitri Papadopoulos Orfanos`_).
- :bdg-dark:`Code` Fix off-by-one error when setting ticks in :func:`~plotting.plot_surf` (:gh:`3105` by `Dimitri Papadopoulos Orfanos`_).
Associated entry in ``CITATION.cff``:

Expand Down
2 changes: 1 addition & 1 deletion doc/changes/0.10.1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Enhancements

- :bdg-info:`Plotting` Surface plotting methods no longer automatically rescale background maps, which, among other things, allows to use curvature sign as a background map (:gh:`3173` by `Alexis Thual`_).

- :func:`~glm.first_level.first_level_from_bids` now takes an optional ``sub_labels`` argument and warns users of given subject labels that are not present in the dataset (:gh:`3351` by `Kevin Sitek`_).
- :bdg-success:`API` :func:`~glm.first_level.first_level_from_bids` now takes an optional ``sub_labels`` argument and warns users of given subject labels that are not present in the dataset (:gh:`3351` by `Kevin Sitek`_).

- :bdg-success:`API` Added special handling of ``param_grid`` and ``cv_params_`` for Decoder objects using models with built-in cross-validation (e.g., ``RidgeCV``, ``RidgeClassifierCV``) (:gh:`3626` by `Michelle Wang`_).

Expand Down
96 changes: 54 additions & 42 deletions doc/changes/latest.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,89 +2,101 @@

.. include:: names.rst

0.10.2.dev
==========
0.10.2
======

**Released September 2023**

HIGHLIGHTS
----------

- :bdg-info:`Plotting` Volume plotting functions like :func:`~plotting.plot_img` now have an optional ``radiological`` parameter, defaulting to ``False``. If ``True``, this will invert the x-axis and ``L`` and ``R`` annotations to confirm to radiological conventional view. (:gh:`3172` by `Konrad Wagstyl`_ and `Yasmin Mzayek`_).

- :bdg-dark:`Code` Update Decoder objects to use the more efficient ``LogisticRegressionCV`` (:gh:`3736` by `Michelle Wang`_).

- :bdg-success:`API` Add ``LassoCV`` as a new estimator option for Decoder objects (:gh:`3781` by `Michelle Wang`_)

- :bdg-success:`API` Add ``vmin`` and ``symmetric_cbar`` arguments to :func:`~nilearn.plotting.plot_img_on_surf` (:gh:`3873` by `Michelle Wang`_).


NEW
---

- Volume plotting functions like :func:`~plotting.plot_img` now have an optional ``radiological`` parameter, defaulting to ``False``. If ``True``, this will invert the x-axis and ``L`` and ``R`` annotations to confirm to radiological conventional view. (:gh:`3172` by `Konrad Wagstyl`_ and `Yasmin Mzayek`_).
- :bdg-info:`Plotting` Volume plotting functions like :func:`~plotting.plot_img` now have an optional ``radiological`` parameter, defaulting to ``False``. If ``True``, this will invert the x-axis and ``L`` and ``R`` annotations to confirm to radiological conventional view. (:gh:`3172` by `Konrad Wagstyl`_ and `Yasmin Mzayek`_).

Fixes
-----

- Fix bug in method ``transform_imgs`` of :class:`~maskers.MultiNiftiMapsMasker` and :class:`~maskers.MultiNiftiLabelsMasker` that would raise an error if a list of ``sample_mask`` was specified to ``fit_transform`` (:gh:`3971` by `Alexandre Cionca`_).
- :bdg-dark:`Code` Fix bug in method ``transform_imgs`` of :class:`~maskers.MultiNiftiMapsMasker` and :class:`~maskers.MultiNiftiLabelsMasker` that would raise an error if a list of ``sample_mask`` was specified to ``fit_transform`` (:gh:`3971` by `Alexandre Cionca`_).

- Fix bug in ``nilearn.plotting.surf_plotting._plot_surf_matplotlib`` that would make vertices transparent when saving in PDF or SVG format (:gh:`3860` by `Mathieu Dugré`_).
- :bdg-info:`Plotting` Fix bug in ``nilearn.plotting.surf_plotting._plot_surf_matplotlib`` that would make vertices transparent when saving in PDF or SVG format (:gh:`3860` by `Mathieu Dugré`_).

- Fix bug that would prevent using ``symmetric_cmap=True`` or the ``avg_method`` argument with :func:`~plotting.plot_surf_roi` (:gh:`3942` by `Rémi Gau`_).
- :bdg-info:`Plotting` Fix bug that would prevent using ``symmetric_cmap=True`` or the ``avg_method`` argument with :func:`~plotting.plot_surf_roi` (:gh:`3942` by `Rémi Gau`_).

- Fixes a bug that would lead to an error when loading a fsaverage surface while relying on numpy >= 1.24.x (:gh:`3644` by `Rémi Gau`_).
- :bdg-dark:`Code` Fixes a bug that would lead to an error when loading a fsaverage surface while relying on numpy >= 1.24.x (:gh:`3644` by `Rémi Gau`_).

- Fix bug that would prevent loading the confounds of a gifti file in actual fmriprep datasets (:gh:`3819` by `Rémi Gau`_).
- :bdg-dark:`Code` Fix bug that would prevent loading the confounds of a gifti file in actual fmriprep datasets (:gh:`3819` by `Rémi Gau`_).

- Fix bug that prevented using dataframes as input for second level GLM when computing contrasts (:gh:`3879` by `Rémi Gau`_).
- :bdg-dark:`Code` Fix bug that prevented using dataframes as input for second level GLM when computing contrasts (:gh:`3879` by `Rémi Gau`_).

- Fix bug in :func:`~glm.first_level.first_level_from_bids` that returned no confound files if the corresponding bold files contained derivatives BIDS entities (:gh:`3742` by `Rémi Gau`_).
- :bdg-dark:`Code` Fix bug in :func:`~glm.first_level.first_level_from_bids` that returned no confound files if the corresponding bold files contained derivatives BIDS entities (:gh:`3742` by `Rémi Gau`_).

- Fix bug in :func:`~glm.first_level.first_level_from_bids` that would throw a warning about ``slice_time_ref`` not being provided even when it was (:gh:`3811` by `Rémi Gau`_).
- :bdg-dark:`Code` Fix bug in :func:`~glm.first_level.first_level_from_bids` that would throw a warning about ``slice_time_ref`` not being provided even when it was (:gh:`3811` by `Rémi Gau`_).

- :bdg-dark:`Code` Fix bug where the ``cv_params_`` attribute of fitter Decoder objects sometimes had missing entries if ``grid_param`` is a sequence of dicts with different keys (:gh:`3733` by `Michelle Wang`_).

- Make the :func:`~nilearn.interfaces.fmriprep.load_confounds` confounds file selection more generic (:gh:`3794` by `Taylor Salo`_).
- :bdg-dark:`Code` Make the :func:`~nilearn.interfaces.fmriprep.load_confounds` confounds file selection more generic (:gh:`3794` by `Taylor Salo`_).

- Change default figsizes to prevent titles from overlapping figure content (:gh:`3797` by `Yasmin Mzayek`_ and see also :gh:`2804` by `Oliver Warrington`_)
- :bdg-info:`Plotting` Change default figure sizes to prevent titles from overlapping figure content (:gh:`3797` by `Yasmin Mzayek`_ and see also :gh:`2804` by `Oliver Warrington`_)

- Relax the :func:`~nilearn.interfaces.fmriprep.load_confounds` confounds selection on ``cosine`` as not all confound files contained the variables (:gh:`3816` by `Hao-Ting Wang`_).
- :bdg-dark:`Code` Relax the :func:`~nilearn.interfaces.fmriprep.load_confounds` confounds selection on ``cosine`` as not all confound files contained the variables (:gh:`3816` by `Hao-Ting Wang`_).

- Fix pathlib.Path not being counted as Niimg-like object in :func:`~image.new_img_like` (:gh:`3723` by `Maximilian Cosmo Sitter`_).
- :bdg-dark:`Code` Fix ``pathlib.Path`` not being counted as Niimg-like object in :func:`~image.new_img_like` (:gh:`3723` by `Maximilian Cosmo Sitter`_).

- Fix ``fit_transform`` behavior to match when ``fit`` method is passed image data (:gh:`3897` by `Yasmin Mzayek`_)
- :bdg-dark:`Code` Fix ``fit_transform`` behavior to match when ``fit`` method is passed image data (:gh:`3897` by `Yasmin Mzayek`_)

- Allow using both vmin and threshold with "plotly" engine to be consistent with "matplotlib" behavior (:gh:`3945` by `Yasmin Mzayek`_)
- :bdg-info:`Plotting` Allow using both vmin and threshold with "plotly" engine to be consistent with "matplotlib" behavior (:gh:`3945` by `Yasmin Mzayek`_)

- Set edgecolors to be the same as facecolors in :func:`~plotting.plot_surf_contours` so that ROI contours are rendered clearly (:gh:`3973` by `Yasmin Mzayek`_)
- :bdg-info:`Plotting` Set edgecolors to be the same as facecolors in :func:`~plotting.plot_surf_contours` so that ROI contours are rendered clearly (:gh:`3973` by `Yasmin Mzayek`_)

- Refactor deprecation of behavior of :func:`~datasets.fetch_atlas_craddock_2012`, :func:`~datasets.fetch_atlas_smith_2009` and :func:`~datasets.fetch_atlas_basc_multiscale_2015` fetchers including using API consistent ``maps`` key (:gh:`3987` by `Yasmin Mzayek`_)
- :bdg-success:`API` Refactor deprecation of behavior of :func:`~datasets.fetch_atlas_craddock_2012`, :func:`~datasets.fetch_atlas_smith_2009` and :func:`~datasets.fetch_atlas_basc_multiscale_2015` fetchers including using API consistent ``maps`` key (:gh:`3987` by `Yasmin Mzayek`_)

Enhancements
------------

- Add cross-reference links to type definitions in public surface functions (:gh:`3857` by `Hao-Ting Wang`_).
- :bdg-secondary:`Doc` Add cross-reference links to type definitions in public surface functions (:gh:`3857` by `Hao-Ting Wang`_).

- Update Decoder objects to use the more efficient ``LogisticRegressionCV`` (:gh:`3736` by `Michelle Wang`_).
- :bdg-dark:`Code` Update Decoder objects to use the more efficient ``LogisticRegressionCV`` (:gh:`3736` by `Michelle Wang`_).

- Throw warning in :func:`~glm.first_level.first_level_from_bids` when using event.tsv files with no trial type column (:gh:`3597` by `Aswin Vijayan`_, `Rémi Gau`_).
- :bdg-dark:`Code` Throw warning in :func:`~glm.first_level.first_level_from_bids` when using event.tsv files with no trial type column (:gh:`3597` by `Aswin Vijayan`_, `Rémi Gau`_).

- Make return key names in the description file of destrieux surface consistent with :func:`~datasets.fetch_atlas_surf_destrieux` (:gh:`3774` by `Tarun Samanta`_).
- :bdg-success:`API` Make return key names in the description file of destrieux surface consistent with :func:`~datasets.fetch_atlas_surf_destrieux` (:gh:`3774` by `Tarun Samanta`_).

- Add ``LassoCV`` as a new estimator option for Decoder objects (:gh:`3781` by `Michelle Wang`_)
- :bdg-success:`API` Add ``LassoCV`` as a new estimator option for Decoder objects (:gh:`3781` by `Michelle Wang`_)

- Add ``vmin`` and ``symmetric_cbar`` arguments to :func:`~nilearn.plotting.plot_img_on_surf` (:gh:`3873` by `Michelle Wang`_).
- :bdg-success:`API` Add ``vmin`` and ``symmetric_cbar`` arguments to :func:`~nilearn.plotting.plot_img_on_surf` (:gh:`3873` by `Michelle Wang`_).

- Improve ``generate_report`` method of maskers by allowing users to pass a cmap argument for plotting image (:gh:`3897` by `Yasmin Mzayek`_)
- :bdg-success:`API` Improve ``generate_report`` method of maskers by allowing users to pass a cmap argument for plotting image (:gh:`3897` by `Yasmin Mzayek`_)

- Improve ``contrasts`` allowing fixed effects on F contrasts (:gh:`3203` by `Bertrand Thirion`_)

Changes
-------

- Validate the content of events files before plotting them (:gh:`3994` by `Rémi Gau`_).
- ``nilearn.glm.first_level.experimental_paradigm.check_events`` will now throw a warning if some events have a 0 second duration and will throw an error if an event has ``NaN`` onset or duration (:gh:`3943` by `Rémi Gau`_).
- Removed old files and test code from deprecated datasets COBRE and NYU resting state (:gh:`3743` by `Michelle Wang`_).
- :bdg-dark:`Code` Validate the content of events files before plotting them (:gh:`3994` by `Rémi Gau`_).
- :bdg-dark:`Code` ``nilearn.glm.first_level.experimental_paradigm.check_events`` will now throw a warning if some events have a 0 second duration and will throw an error if an event has ``NaN`` onset or duration (:gh:`3943` by `Rémi Gau`_).
- :bdg-secondary:`Maint` Removed old files and test code from deprecated datasets COBRE and NYU resting state (:gh:`3743` by `Michelle Wang`_).
- :bdg-secondary:`Maint` PEP8 and isort compliance extended to the whole nilearn codebase. (:gh:`3538`, :gh:`3566`, :gh:`3548`, :gh:`3556`, :gh:`3601`, :gh:`3609`, :gh:`3646`, :gh:`3650`, :gh:`3647`, :gh:`3640`, :gh:`3615`, :gh:`3614`, :gh:`3648`, :gh:`#3651` by `Rémi Gau`_).
- :bdg-secondary:`Maint` Finish applying black formatting to most of the codebase. (:gh:`3836`, :gh:`3833`, :gh:`3827`, :gh:`3810`, :gh:`3803`, :gh:`3802`, :gh:`3795`, :gh:`3790`, :gh:`3783`, :gh:`3777` by `Rémi Gau`_).
- :bdg-danger:`Deprecation` Empty region signals resulting from applying ``mask_img`` in :class:`~maskers.NiftiLabelsMasker` will no longer be kept in release 0.15.
Meanwhile, use ``keep_masked_labels`` parameter when initializing the :class:`~maskers.NiftiLabelsMasker` object to enable/disable this behavior. (:gh:`3722` by `Mohammad Torabi`_).
- :bdg-danger:`Deprecation` Empty region signals resulting from applying ``mask_img`` in :class:`~maskers.NiftiMapsMasker` will no longer be kept in release 0.15.
Meanwhile, use ``keep_masked_maps`` parameter when initializing the :class:`~maskers.NiftiMapsMasker` object to enable/disable this behavior. (:gh:`3732` by `Mohammad Torabi`_).
- Removed mention of license in "header" (:gh:`3838` by `Czarina Sy`_).
- Configure plots in example gallery for better rendering (:gh:`3753` by `Yasmin Mzayek`_)
- Make one_mesh_info and full_brain_info into private functions _one_mesh_info and _full_brain_info (:gh:`3847` by `Rahul Brito`_)
- Refactor error raising tests using context managers (:gh:`3854` BY `François Paugam`_)
- Added warning to deprecate ``darkness`` in ``surf_plotting._compute_facecolors_matplotlib`` and ``html_surface._get_vertexcolor`` (:gh`3855` by `Alisha Kodibagkar`_)
- :bdg-danger:`Deprecation` Empty region signals resulting from applying ``mask_img`` in :class:`~maskers.NiftiLabelsMasker` will no longer be kept in release 0.15. Meanwhile, use ``keep_masked_labels`` parameter when initializing the :class:`~maskers.NiftiLabelsMasker` object to enable/disable this behavior. (:gh:`3722` by `Mohammad Torabi`_).
- :bdg-danger:`Deprecation` Empty region signals resulting from applying ``mask_img`` in :class:`~maskers.NiftiMapsMasker` will no longer be kept in release 0.15. Meanwhile, use ``keep_masked_maps`` parameter when initializing the :class:`~maskers.NiftiMapsMasker` object to enable/disable this behavior. (:gh:`3732` by `Mohammad Torabi`_).
- :bdg-secondary:`Maint` Removed mention of license in "header" (:gh:`3838` by `Czarina Sy`_).
- :bdg-secondary:`Doc` Configure plots in example gallery for better rendering (:gh:`3753` by `Yasmin Mzayek`_)
- :bdg-secondary:`Maint` Make one_mesh_info and full_brain_info into private functions _one_mesh_info and _full_brain_info (:gh:`3847` by `Rahul Brito`_)
- :bdg-secondary:`Maint` Refactor error raising tests using context managers (:gh:`3854` BY `François Paugam`_)
- :bdg-danger:`Deprecation` Added warning to deprecate ``darkness`` in ``surf_plotting._compute_facecolors_matplotlib`` and ``html_surface._get_vertexcolor`` (:gh`3855` by `Alisha Kodibagkar`_)
- :bdg-secondary:`Doc` Replace skipped doctests with default code-blocks (:gh:`3681` in by `Patrick Sadil`_)
- Move the ``~nilearn.plotting.html_surface._mix_colormaps`` to ``cm.py`` in :mod:`~nilearn.plotting` (:gh:`3919` by `Ahmad Chamma`_)
- Remove deprecation decorator from ``~nilearn.glm.regression`` (:gh:`3921` by `Ahmad Chamma`_)
- Expose ``standardize`` in :func:`~plotting.plot_carpet` and :class:`~connectome.ConnectivityMeasure` to handle "zscore" deprecation (:gh:`3927` by `Yasmin Mzayek`_).
- Example :ref:`sphx_glr_auto_examples_01_plotting_plot_prob_atlas.py` is shortened to speed up build time (:gh:`3934` by `Yasmin Mzayek`_)
- :bdg-secondary:`Maint` Move the ``~nilearn.plotting.html_surface._mix_colormaps`` to ``cm.py`` in :mod:`~nilearn.plotting` (:gh:`3919` by `Ahmad Chamma`_)
- :bdg-secondary:`Maint` Remove deprecation decorator from ``~nilearn.glm.regression`` (:gh:`3921` by `Ahmad Chamma`_)
- :bdg-success:`API` Expose ``standardize`` in :func:`~plotting.plot_carpet` and :class:`~connectome.ConnectivityMeasure` to handle "zscore" deprecation (:gh:`3927` by `Yasmin Mzayek`_).
- :bdg-secondary:`Doc` Example :ref:`sphx_glr_auto_examples_01_plotting_plot_prob_atlas.py` is shortened to speed up build time (:gh:`3934` by `Yasmin Mzayek`_)

0 comments on commit 8090e3f

Please sign in to comment.